Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen e2e security policy traffic #971

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

zhengxiexie
Copy link
Contributor

No description provided.

@zhengxiexie
Copy link
Contributor Author

/e2e

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.37%. Comparing base (a1693cd) to head (be5e7cb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   73.37%   73.37%           
=======================================
  Files         118      118           
  Lines       16394    16394           
=======================================
  Hits        12029    12029           
  Misses       3581     3581           
  Partials      784      784           
Flag Coverage Δ
unit-tests 73.37% <ø> (ø)

@zhengxiexie
Copy link
Contributor Author

/e2e

3 similar comments
@wenyingd
Copy link
Contributor

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/traffic branch 4 times, most recently from 2852d90 to e4eb24e Compare December 18, 2024 04:55
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/traffic branch 2 times, most recently from 41c7a43 to 4d3aa5a Compare December 18, 2024 06:32
test/e2e/framework.go Outdated Show resolved Hide resolved
test/e2e/framework.go Outdated Show resolved Hide resolved
test/e2e/nsx_security_policy_test.go Outdated Show resolved Hide resolved
test/e2e/nsx_security_policy_test.go Outdated Show resolved Hide resolved
test/e2e/nsx_security_policy_test.go Show resolved Hide resolved
test/e2e/nsx_security_policy_test.go Outdated Show resolved Hide resolved
test/e2e/framework.go Show resolved Hide resolved
test/e2e/framework.go Show resolved Hide resolved
test/e2e/nsx_security_policy_test.go Outdated Show resolved Hide resolved
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/traffic branch from 4d3aa5a to 13bc0ea Compare December 18, 2024 08:18
test/e2e/framework.go Outdated Show resolved Hide resolved
test/e2e/framework.go Outdated Show resolved Hide resolved
test/e2e/framework.go Show resolved Hide resolved
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/traffic branch 4 times, most recently from 33a17e0 to 0eaf559 Compare December 18, 2024 10:00
@wenqiq
Copy link
Contributor

wenqiq commented Dec 19, 2024

The e2e test failed, please check.

@zhengxiexie
Copy link
Contributor Author

/e2e

1 similar comment
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/traffic branch 2 times, most recently from 6c67f29 to 02eecf9 Compare December 19, 2024 07:32
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/traffic branch from 02eecf9 to be5e7cb Compare December 19, 2024 09:26
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wenqiq wenqiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Regarding the use of YAML or code for creating resources in e2e testing, IMO, using YAML makes debugging more convenient, while using code allows errors to be detected promptly when CRD fields change. Of course, this is not a strict requirement.

@zhengxiexie zhengxiexie merged commit 86c0d65 into main Dec 20, 2024
2 checks passed
zhengxiexie added a commit that referenced this pull request Dec 20, 2024
…affic

[CP]Reopen e2e security policy traffic(#971)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants