-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopen e2e security policy traffic #971
Conversation
/e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 118 118
Lines 16394 16394
=======================================
Hits 12029 12029
Misses 3581 3581
Partials 784 784
|
/e2e |
3 similar comments
/e2e |
/e2e |
/e2e |
2852d90
to
e4eb24e
Compare
/e2e |
41c7a43
to
4d3aa5a
Compare
test/e2e/manifest/testSecurityPolicy/rule-in-rule-applied-to-with-src.yaml
Show resolved
Hide resolved
4d3aa5a
to
13bc0ea
Compare
33a17e0
to
0eaf559
Compare
The e2e test failed, please check. |
/e2e |
1 similar comment
/e2e |
6c67f29
to
02eecf9
Compare
02eecf9
to
be5e7cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Regarding the use of YAML or code for creating resources in e2e testing, IMO, using YAML makes debugging more convenient, while using code allows errors to be detected promptly when CRD fields change. Of course, this is not a strict requirement.
…affic [CP]Reopen e2e security policy traffic(#971)
No description provided.