Temporarily disable traffic check in SP #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdengyun
force-pushed
the
Temporarily-disable-traffic-check-in-sp
branch
from
35d549f to
f7c52f2
Compare
timdengyun
force-pushed
the
Temporarily-disable-traffic-check-in-sp
branch
3 times, most recently
from
29932b7 to
30497ad
Compare
|
/e2e |
timdengyun
force-pushed
the
Temporarily-disable-traffic-check-in-sp
branch
2 times, most recently
from
60a7945 to
93bf870
Compare
|
/e2e |
This patch is to temporarily disable traffic check and named ports check in Security Policy e2e test. In VPC mode, currently, it's unable to create a subnetport in k8s env, so, we can not check pod running and pod traffic. Also, creating named port related security policy will fail as well because there are no running pods created for the named port security policy. We still check securitypolicy creation, update and deletion for e2e test.
timdengyun
force-pushed
the
Temporarily-disable-traffic-check-in-sp
branch
from
93bf870 to
fb49cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to temporarily disable traffic check and named ports
check in Security Policy e2e test.
In VPC mode, currently, it's unable to create a subnetport in k8s env,
so, we can not check pod running and pod traffic.
Also, creating named port related security policy will fail as well
because there are no running pods created for the named port security policy.
We still check securitypolicy creation, update and deletion for e2e test.