vpc_dev branch rebase to main branch #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to pass param for enable_vpc_network when validate VPC options under NsxConfig.
Just run `make generated` to generate.
For example, SubnetCR and IPPoolCR both need query IpAddressPoolBlockSubnet we should filter them by tags.
Create the common method used by other modules. When using gomonkey to test the method, encounter the problem that the mocked method doesn't take effect, fix it by adding -gcflags=all=-l option to prohibit inline optimization.
Add VPC related options in NsxConfig.
Need to pass param for enable_vpc_network when validate VPC options under NsxConfig.
Leverage controller-runtime builtin leader-election to support HA.
Refactor the name convention.
Leverage controller-runtime builtin leader-election to support HA.
Fix make manifests error. Fix copying files differences on linux and mac.
Change VPC type define from VPC to Vpc according to nsx resource definition.
Add service to implement checking realize status of entity with retries.
If user forgets to set ha.enable but set replica 2, it would be confusing, so set EnableHA default true to avoid this undefined behaviour. Besides, NCP ha.enable default value is true, keep it aligned.
Change the mock nsxop.ini file as the formal ini format; Initialize the config options in a central place instead of in main; Warp HAEnabled in function, and add UT.
Upgrade golang to v1.19.10 to escape the CVEs prior to 1.19.10.
Upgrade vsphere-automation-sdk-go SDK
SDK has updated the Vpc struct. Update UT for it
Add StaticRoute controller. Add sample yaml file
Initializing logger before loading operator config file, otherwise, the log info will not be logged
Add subnet/subnetset controller to reconcile subnet/subnetset CRD. And add subnet service to perform NSX subnet CRUD operations.
Subnet service will be register to mediator, so that some functions need to be moved to controller side to avoid cycle import.
Refactor NSXCheckVersionFor. Start those vpc controllers only when EnableVPCNetwork is true and nsx version support vpc.
If ca_file found, use ca_file to verify server certificate Update ut since NewConfig interface updated
Since Operate function body is nil. Using Add to replace Operate. Remove some redundant code from UT
Since ca patch update ca_file from string to []string, update parameter while creating config
This patch is to change branch name in github workflow make file in order to make UT running in vpc_dev branch as well.
…mware-tanzu#311) Add EnableCertRotation property in NSXServiceAccount.Spec. Cache CA content in memory. Populate CA content to Secret when processing NSXServiceAccount create event. Check all Secrets' ca.crt are up-to-date when first NSXServiceAccount GC finished. Update if needed. Check all Secrets' client cert need renew every 720 GC interval. Renew client cert if cert will expire in 7d when rotation is supported (NSXT >=4.1.3 and EnableCertRotation is true). Use 365d instead of 3650d for new client cert when rotation is supported (NSXT >=4.1.3 and EnableCertRotation is true). Signed-off-by: gran <[email protected]>
gran-vmv
reviewed
Nov 22, 2023
|
/e2e |
1 similar comment
|
/e2e |
|
pls add #401 |
When running `make test`, the generated nsx.vmware.com_ippools.yaml is different from the current one, the CRD definition misses validation.
|
|
LGTM |
timdengyun
requested review from
lxiaopei,
seanpang-vmware,
gran-vmv,
zhengxiexie,
jwsui,
TaoZou1 and
heypnus
|
Sync pkg/apis/nsx.vmware.com/v1alpha1/2 with pkg/apis/v1alpha1/2. Add `go mod init` `go mod tidy` in pkg/client
Sync pkg/apis/nsx.vmware.com/v1alpha1/zz_generated.deepcopy.go is the same with pkg/apis/v1alpha1/zz_generated.deepcopy.go
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to rebase vpc_dev to main branch in order to merge back all VPC dev PRs to main branch.
Hereafter, we will use main branch as our dev branch.