-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly check 5 GPRRs for VPC RealizedState #1016
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yanjun Zhou <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
+ Coverage 74.24% 74.36% +0.12%
==========================================
Files 118 118
Lines 16398 16421 +23
==========================================
+ Hits 12175 12212 +37
+ Misses 3453 3439 -14
Partials 770 770
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole logic LGTM, Just a nit comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole logic LGTM, just a nit comment.
@@ -43,6 +43,31 @@ var ( | |||
EnforceRevisionCheckParam = false | |||
) | |||
|
|||
func GetGPRRTypeList(id string) []nsxutil.GPRRType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does GPRR stands for? it's good that we add some description for it.
No description provided.