Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check 5 GPRRs for VPC RealizedState #1016

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.36%. Comparing base (6c54354) to head (b164a23).

Files with missing lines Patch % Lines
pkg/nsx/services/vpc/vpc.go 92.30% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
+ Coverage   74.24%   74.36%   +0.12%     
==========================================
  Files         118      118              
  Lines       16398    16421      +23     
==========================================
+ Hits        12175    12212      +37     
+ Misses       3453     3439      -14     
  Partials      770      770              
Flag Coverage Δ
unit-tests 74.36% <94.11%> (+0.12%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/common/types.go 100.00% <ø> (ø)
pkg/nsx/services/realizestate/realize_state.go 100.00% <100.00%> (ø)
pkg/nsx/services/subnet/subnet.go 70.27% <100.00%> (ø)
pkg/nsx/services/subnetport/subnetport.go 82.56% <100.00%> (ø)
pkg/nsx/util/utils.go 65.38% <ø> (ø)
pkg/nsx/services/vpc/vpc.go 57.43% <92.30%> (+2.34%) ⬆️

Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole logic LGTM, Just a nit comment

Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole logic LGTM, just a nit comment.

@@ -43,6 +43,31 @@ var (
EnforceRevisionCheckParam = false
)

func GetGPRRTypeList(id string) []nsxutil.GPRRType {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does GPRR stands for? it's good that we add some description for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants