Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyFunc for shared resources #1013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Jan 24, 2025

While listing the resources in cleanup, each resource type should be added in keyFunc.
Add shared resources to keyFunc

Test Done:

  1. upload the wcpsvc
  2. disable the cluster
  3. check if the resources have been clean

While listing the resources in cleanup, each resource type should
be added in keyFunc.
Add shared resources to keyFunc
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.17%. Comparing base (954ed89) to head (0d04ef1).

Files with missing lines Patch % Lines
pkg/nsx/services/vpc/store.go 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   74.22%   74.17%   -0.06%     
==========================================
  Files         118      118              
  Lines       16378    16390      +12     
==========================================
  Hits        12157    12157              
- Misses       3451     3463      +12     
  Partials      770      770              
Flag Coverage Δ
unit-tests 74.17% <0.00%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
pkg/nsx/services/vpc/store.go 59.81% <0.00%> (-7.56%) ⬇️

@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Jan 24, 2025

/e2e

1 similar comment
@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Jan 26, 2025

/e2e

@timdengyun
Copy link
Contributor

we see release branch PR: #1012 has been merged, do we merge this PR in main as well @TaoZou1

Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants