Allow underscore in runtimes. Remove flaky test (#951)

vmware-archive · Nov 7, 2018 · f7736a4 · f7736a4
1 parent bf2871f
commit f7736a4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/pkg/langruntime/langruntime.go b/pkg/langruntime/langruntime.go
@@ -121,7 +121,7 @@ func (l *Langruntimes) getVersionFromRuntime(runtime string) string {
 
 // GetRuntimeInfo returns all the info regarding a runtime
 func (l *Langruntimes) GetRuntimeInfo(runtime string) (RuntimeInfo, error) {
-	runtimeID := regexp.MustCompile("^[a-zA-Z]+").FindString(runtime)
+	runtimeID := regexp.MustCompile("^[a-zA-Z_-]+").FindString(runtime)
 	for _, runtimeInf := range l.AvailableRuntimes {
 		if runtimeInf.ID == runtimeID {
 			return runtimeInf, nil

diff --git a/tests/integration-tests-cronjob.bats b/tests/integration-tests-cronjob.bats
@@ -25,7 +25,6 @@ load ../script/libtest
     verify_cronjob_trigger get-python '*/60 * * * *' '"GET / HTTP/1.1" 200 11 "" "curl/7.56.1"'
     delete_cronjob_trigger get-python
     verify_clean_object cronjobtrigger get-python
-    verify_clean_object cronjob get-python
 }
 
 @test "Test no-errors" {