Adjust startup ASCII art.

[mserajnik]

🍰 Pullrequest

This adjusts the ASCII art that's printed at mangosd startup to spell VMaNGOS instead of MaNGOS. I've tried to keep the V in the same style as the rest of the letters.

The (defunct) http://getmangos.com URL that is displayed next to the ASCII art is also replaced with https://github.com/vmangos instead.

The PR also implements a few more adjustments based on the feedback I've gotten here so far. If they are unwanted, let me know and I will remove them:

1. It moves the a up one line
2. It makes the O wider by one character to match the width of the G for more visual balance
3. It moves the URL next to the ASCII art down one line to give it some space and make it more readable
4. It removes the redundant VMaNGOS : https://github.com/vmangos print right after the ASCII art

Here's also a link to a Gist with some more permutations of those additional adjustments: https://gist.github.com/mserajnik/07295959b696661ccad4e3b115407171
The implemented ASCII art changes match variant d) from the Gist, with the addition of moving the URL down a line and removing the redundant print of the URL below.

Proof

Here's how it currently looks:

MM   MM         MM   MM  MMMMM   MMMM   MMMMM
MM   MM         MM   MM MMM MMM MM  MM MMM MMM
MMM MMM         MMM  MM MMM MMM MM  MM MMM
MM M MM         MMMM MM MMM     MM  MM  MMM
MM M MM  MMMMM  MM MMMM MMM     MM  MM   MMM
MM M MM M   MMM MM  MMM MMMMMMM MM  MM    MMM
MM   MM     MMM MM   MM MM  MMM MM  MM     MMM
MM   MM MMMMMMM MM   MM MMM MMM MM  MM MMM MMM
MM   MM MM  MMM MM   MM  MMMMMM  MMMM   MMMMM
        MM  MMM http://getmangos.com
        MMMMMM

VMaNGOS : https://github.com/vmangos

And here's how it will look with this PR merged:

MM     MM MM   MM         MM   MM  MMMMM   MMMMM   MMMMM
MM     MM MM   MM         MM   MM MMM MMM MM   MM MMM MMM
 MM   MM  MMM MMM         MMM  MM MMM MMM MM   MM MMM
 MM   MM  MM M MM  MMMMM  MMMM MM MMM     MM   MM  MMM
  MM MM   MM M MM M   MMM MM MMMM MMM     MM   MM   MMM
  MM MM   MM M MM     MMM MM  MMM MMMMMMM MM   MM    MMM
   MMM    MM   MM MMMMMMM MM   MM MM  MMM MM   MM     MMM
   MMM    MM   MM MM  MMM MM   MM MMM MMM MM   MM MMM MMM
    M     MM   MM MM  MMM MM   MM  MMMMMM  MMMMM   MMMMM
                  MMMMMM
                          https://github.com/vmangos

Issues

• None

How2Test

• Start mangosd
• Observe the adjusted ASCII art

Todo / Checklist

• None

[0blu]

Super cool PR!
But I find it a bit hard to read the URL right below the N.
TrinityCore has a bit more space.

[mserajnik]

But I find it a bit hard to read the URL right below the N.

Yeah, that’s why I suggested it could also be moved down (or removed). 😄

[mserajnik]

Here's my preferred variant d) (a moved up one line, O widened by one character) from the permutations I posted in the Gist with the URL moved further down (but not shifted to the left):

MM     MM MM   MM         MM   MM  MMMMM   MMMMM   MMMMM
MM     MM MM   MM         MM   MM MMM MMM MM   MM MMM MMM
 MM   MM  MMM MMM         MMM  MM MMM MMM MM   MM MMM
 MM   MM  MM M MM  MMMMM  MMMM MM MMM     MM   MM  MMM
  MM MM   MM M MM M   MMM MM MMMM MMM     MM   MM   MMM
  MM MM   MM M MM     MMM MM  MMM MMMMMMM MM   MM    MMM
   MMM    MM   MM MMMMMMM MM   MM MM  MMM MM   MM     MMM
   MMM    MM   MM MM  MMM MM   MM MMM MMM MM   MM MMM MMM
    M     MM   MM MM  MMM MM   MM  MMMMMM  MMMMM   MMMMM
                  MMMMMM
                          https://github.com/vmangos

I've also changed the URL from the repository to the organisation (https://github.com/vmangos) since that's probably the better choice.
I guess the VMaNGOS : https://github.com/vmangos print below could also be removed instead then.

What do you think?

[cpevors]

I don’t think the URL should be removed, but the referenced variant D certainly does look more legible. Super cool!

[mserajnik]

I don’t think the URL should be removed, but the referenced variant D certainly does look more legible. Super cool!

Thanks for the feedback!

What about leaving the URL next to the ASCII art and instead removing the VMaNGOS : https://github.com/vmangos print that comes right after it (as suggested in my previous comment)? Or is that what you meant?

[cpevors]

I don’t think the URL should be removed, but the referenced variant D certainly does look more legible. Super cool!

Thanks for the feedback!

What about leaving the URL next to the ASCII art and instead removing the VMaNGOS : https://github.com/vmangos print that comes right after it (as suggested in my previous comment)? Or is that what you meant?

I’m in complete agreement with this approach. The URL next to the art looks great; the print that comes after would be needlessly redundant, and I’d advocate for its removal.

[mserajnik]

MM     MM MM   MM         MM   MM  MMMMM   MMMMM   MMMMM
MM     MM MM   MM         MM   MM MMM MMM MM   MM MMM MMM
 MM   MM  MMM MMM         MMM  MM MMM MMM MM   MM MMM
 MM   MM  MM M MM  MMMMM  MMMM MM MMM     MM   MM  MMM
  MM MM   MM M MM M   MMM MM MMMM MMM     MM   MM   MMM
  MM MM   MM M MM     MMM MM  MMM MMMMMMM MM   MM    MMM
   MMM    MM   MM MMMMMMM MM   MM MM  MMM MM   MM     MMM
   MMM    MM   MM MM  MMM MM   MM MMM MMM MM   MM MMM MMM
    M     MM   MM MM  MMM MM   MM  MMMMMM  MMMMM   MMMMM
                  MMMMMM
                          https://github.com/vmangos

Based on the feedback so far I've adjusted the PR to implement this variant d), with the addition of moving the URL down a line and removing the redundant print of the URL below (the VMaNGOS : https://github.com/vmangos).