-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSL support #47
base: master
Are you sure you want to change the base?
Add SSL support #47
Conversation
Is this feature ready to be merged in? Would be very useful. |
Am I correct in assuming that this PR adds support for the lumberjack protocol? |
@vellamike the library already implements the logstash json over HTTP protocol. This patch adds HTTPS support to the transport component. |
@skwashd my understanding is that the communication here is done over TCP, with no HTTP layer, and that logstash itself supports a custom TCP-like protocol called lumberjack which there is no python support for (though it is supported in node) |
Code looks good. Fairly simple changes for such a major feature addition. I would love for this to get merged. It's something we really need for a project. |
@vellamike sorry you're right it is over TCP (now with optional SSL support). |
See vklochan#28 Adds initial support for SSL. The implementation supports the following features: * Remote certificate validation * Custom CA bundles * Client side certs SSL is now on by default.
@vklochan I've rebased current master into the patch. Is there anything else I need to do in order to get this merged? |
Can we have any update in this PR? This package does an amazing job for me but I need the SSL suport to use it. |
Could we please get this merged? It would be very useful. |
Can you make it compatible with python3? it complains that makeSocket does not accepts any arguments.
To:
|
@vklochan is there any thing I can do to help get this merged? Do you need a comaintainer to assist with cleaning up the backlog of issues and PRs? |
@skwashd Finally, what did you do? |
Adds initial support for SSL. The implementation supports the following
features:
SSL is now on by default.
Fixes #28