Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL Support? #28

Open
reiven opened this issue Mar 25, 2015 · 5 comments
Open

SSL Support? #28

reiven opened this issue Mar 25, 2015 · 5 comments

Comments

@reiven
Copy link

reiven commented Mar 25, 2015

Hi

I want to know if python-logstash has SSL support, because i cannot find any way to define custom certificate.

Thanks
@ghost
Copy link

ghost commented Jun 12, 2015

Same issue here, TLS/SSL support would be nice.

@reiven
Copy link
Author

reiven commented Oct 16, 2015

ping

@skwashd
Copy link

skwashd commented Jan 22, 2016

I had a quick look at the code to see if this was possible. It looks to me like the easiest way to achieve this is to implement makeSocket() in the TCPLogstashHandler class as has been done in @klynch's logstash_handler library.

@vklochan would you be likely to accept a patch that does something like that?

@csparpa
Copy link

csparpa commented Jan 25, 2016

Ping for @vklochan

The possibility to encrypt logs is a super useful feature!

I think the one proposed by @skwashd is an easy-winning patch... If you want I can help out

@marji
Copy link

marji commented Feb 3, 2016

+1 please.

skwashd added a commit to skwashd/python-logstash that referenced this issue Mar 14, 2016
@skwashd
Add SSL support
34873d1 
See vklochan#28

Adds initial support for SSL. The implementation supports the following
features:

* Remote certificate validation
* Custom CA bundles
* Client side certs

SSL is now on by default.
@skwashd skwashd mentioned this issue Mar 14, 2016
Open
skwashd added a commit to skwashd/python-logstash that referenced this issue Aug 10, 2016
@skwashd
Add SSL support
f0f7eba 
See vklochan#28

Adds initial support for SSL. The implementation supports the following
features:

* Remote certificate validation
* Custom CA bundles
* Client side certs

SSL is now on by default.
@superduper superduper mentioned this issue Aug 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skwashd @reiven @marji @csparpa