Fail build if cargo build does not succeed

vita-rust · Oct 8, 2023 · 308b44e · 308b44e
1 parent 9660861
commit 308b44e
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 49 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/commands/build.rs b/src/commands/build.rs
@@ -105,6 +105,7 @@ impl<'a> BuildContext<'a> {
     }
 }
 
+#[derive(Debug)]
 struct ExecutableArtifact {
     artifact: Artifact,
     meta: PackageMetadata,
@@ -273,15 +274,21 @@ impl<'a> BuildContext<'a> {
             .collect::<io::Result<_>>()
             .context("Unable to parse build stdout")?;
 
-        messages
+        let artifacts = messages
             .iter()
             .rev()
             .filter_map(|m| match m {
                 Message::CompilerArtifact(art) if art.executable.is_some() => Some(art.clone()),
                 _ => None,
             })
             .map(ExecutableArtifact::new)
-            .collect()
+            .collect::<anyhow::Result<_>>()?;
+
+        if !process.wait_with_output()?.status.success() {
+            bail!("cargo build failed")
+        }
+
+        Ok(artifacts)
     }
 
     fn strip(&self, art: &ExecutableArtifact) -> anyhow::Result<()> {