feat: slpk from local filesystem feature #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@belom88 Please review as soon as you can |
belom88
requested changes
Nov 27, 2024
| const fileSystem = new ZipFileSystem(archive); | ||
| options.fetch = fileSystem.fetch.bind(fileSystem) as (filename: string) => Promise<Response>; | ||
| } catch (e) { | ||
| console.log("error", e); |
There was a problem hiding this comment.
Suggested change
| console.log("error", e); | |
| console.error(e); |
src/pages/viewer-app/viewer-app.tsx
Outdated
| @@ -238,8 +248,9 @@ export const ViewerApp = () => { | |||
| setSelectedFeatureAttributes(null); | |||
| setSelectedFeatureIndex(-1); | |||
| if (buildingExplorerOpened && tilesetsData[0]) { | |||
| const tilesetDataUrl = typeof tilesetsData[0].url === "string" ? tilesetsData[0].url : tilesetsData[0].url.name; | |||
There was a problem hiding this comment.
Some utility function getDatasetUrl(dataset: LayerExample | TilesetMetadata) => string. You reuse this pattern many times. This function would make the code more readable.
Suggested change
| const tilesetDataUrl = typeof tilesetsData[0].url === "string" ? tilesetsData[0].url : tilesetsData[0].url.name; | |
| const tilesetDataUrl = getDatasetUrl(tilesetsData[0]); |
Comment on lines
+223
to
+228
| let params = { tilesetUrl: "" as string | File, token: "" }; | ||
| if (typeof layer.url === "string") { | ||
| params = parseTilesetUrlParams(layer.url, layer); | ||
| } else { | ||
| params.tilesetUrl = layer.url; | ||
| } |
There was a problem hiding this comment.
Why this part is different in src/pages/debug-app/debug-app.tsx and src/components/comparison/comparison-side/comparison-side.tsx?
belom88
approved these changes
Nov 28, 2024
src/utils/layer-utils.ts
Outdated
| @@ -95,7 +95,7 @@ export const findExampleAndUpdateWithViewState = ( | |||
|
|
|||
| for (const example of examplesCopy) { | |||
| // We can't compare by tileset.url === example.url because BSL and Scene examples url is not loaded as tileset. | |||
| if (tileset.url.includes(example.url) && !example.viewState) { | |||
| if (tileset.url.includes(typeof example.url === "string" ? example.url : example.url.name) && !example.viewState) { | |||
There was a problem hiding this comment.
Suggested change
| if (tileset.url.includes(typeof example.url === "string" ? example.url : example.url.name) && !example.viewState) { | |
| if (tileset.url.includes(getLayerUrl(example.url)) && !example.viewState) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of changes for slpk from local filesystem feature