Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(basemap): Add and select basemap #366

Merged
merged 17 commits into from
Apr 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint issues
mspivak-actionengine committed Mar 25, 2024
commit b482793694f976cb1ca998e32a43a13c8a2b9899
Original file line number Diff line number Diff line change
@@ -15,7 +15,10 @@ describe("Input Text", () => {
onChange={onChange}
/>
);

expect(dom).toBeDefined();
if (!dom) {
return;
}
const input: HTMLSelectElement | null =
dom.container.querySelector("select");
const inputLabel: HTMLLabelElement | null =
@@ -36,6 +39,10 @@ describe("Input Text", () => {
onChange={onChange}
/>
);
expect(dom).toBeDefined();
if (!dom) {
return;
}
const input: HTMLSelectElement | null =
dom.container.querySelector("select");
const inputLabel: HTMLLabelElement | null =
@@ -84,6 +91,10 @@ describe("Input Text", () => {
onChange={onChange}
/>
);
expect(dom).toBeDefined();
if (!dom) {
return;
}
const input: HTMLSelectElement | null =
dom.container.querySelector("select");


Unchanged files with check annotations Beta

/**
* TODO: Add types to component
*/
export const App = () => {

Check warning on line 143 in src/app.tsx

GitHub Actions / Linter

Missing return type on function
const [theme, setTheme] = useState<Theme>(Theme.Dark);
const [showHelp, setShowHelp] = useState<boolean>(false);
const handleHelpClick = () => {

Check warning on line 147 in src/app.tsx

GitHub Actions / Linter

Missing return type on function
setShowHelp((prevValue) => !prevValue);
};
onClick,
children,
type = "button",
}: ActionButtonProps) => {

Check warning on line 69 in src/components/action-button/action-button.tsx

GitHub Actions / Linter

Missing return type on function
const getButtonComponent = (): any => {
switch (variant) {
case ActionButtonVariant.primary:
size,
children,
onClick,
}: ActionIconButtonProps) => {

Check warning on line 72 in src/components/action-icon-button/action-icon-button.tsx

GitHub Actions / Linter

Missing return type on function
const grayed = style === "disabled";
const theme = useTheme();
const onClickMock = jest.fn();
const callRender = (renderFunc, props) => {

Check warning on line 8 in src/components/arcgis-user/arcgis-user.spec.tsx

GitHub Actions / Linter

Missing return type on function
return renderFunc(<AcrGisUser onClick={onClickMock} {...props} />);
};
onClick?: () => void;
}
export const AcrGisUser = ({ children, onClick }: ArcGisUserProps) => {

Check warning on line 45 in src/components/arcgis-user/arcgis-user.tsx

GitHub Actions / Linter

Missing return type on function
return (
<Container>
<UserInfo>{children}</UserInfo>
};
});
const callRender = (renderFunc) => {

Check warning on line 10 in src/components/arcgis-wrapper/arcgis-wrapper.spec.tsx

GitHub Actions / Linter

Missing return type on function
return renderFunc(<Map />);
};
// eslint-disable-next-line @typescript-eslint/no-empty-function
onTileUnload = () => {},
onTraversalComplete = (selectedTiles) => selectedTiles,
}: ArcGisMapProps) => {

Check warning on line 141 in src/components/arcgis-wrapper/arcgis-wrapper.tsx

GitHub Actions / Linter

Missing return type on function
const {
showMinimap,
loadTiles,
interactionState,
viewState,
viewId,
}) => {

Check warning on line 176 in src/components/arcgis-wrapper/arcgis-wrapper.tsx

GitHub Actions / Linter

Missing return type on function
const {
longitude,
latitude,
} = viewState;
const viewportCenterTerrainElevation =
getElevationByCentralTile(longitude, latitude, terrainTiles) ?? 0;

Check warning on line 184 in src/components/arcgis-wrapper/arcgis-wrapper.tsx

GitHub Actions / Linter

Unsafe argument of type `any` assigned to a parameter of type `number`
let cameraTerrainElevation: number | null = null;
if (currentViewport) {