feat(texture): support selecting textures #356
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@belom88 please review |
There was a problem hiding this comment.
It is unnecessary complexity with textures initialization and adding textures via uv-debug-texture-slice. The responsibilities of slices are clear:
icon-list-slice- manage lists;uv-debug-texture-slice- load the texture when the url has changed.
How they should work together:
- Init the list directly in
icon-list-slice. It is OK that there will be "list of textures" in this slice initialized. It is not a generic component for a UI library. All add and remove list item logic should dispatch directly to this slice; uv-debug-texture-slicedoesn't know about multiple textures. It stores only a loadedImageBitmap. Addurlargument tofetchUVDebugTexture. Make sure that the texture is null during requests. Probably, need to track request status (idle,loading,succeded,failed);- We should have a
useEffectinDeckglWrapper- it should dispatchfetchUVDebugTexturewhen selected texture has changed
| const uvDebugTexture = useAppSelector(selectUVDebugTexture(imageUrl)); | ||
| const uvDebugTextureRef = useRef<ImageBitmap | null>(null); | ||
| uvDebugTextureRef.current = uvDebugTexture; | ||
| const [needTransitionToTileset, setNeedTransitionToTileset] = useState(false); | ||
|
|
||
| const [forceRefresh, setForceRefresh] = useState(false); |
There was a problem hiding this comment.
forceRefresh is changed but never used
There was a problem hiding this comment.
After the texture is replaced in the tileset (in useEffect) we change the variable forceRefresh in order to start re-rendering.
| action: PayloadAction<{ imageUrl: string; image: ImageBitmap | null }> | ||
| action: PayloadAction<{ | ||
| imageUrl: string; | ||
| image: ImageBitmap | null; |
There was a problem hiding this comment.
Does it make sense to push null to image?
There was a problem hiding this comment.
Removed null from the type.
No description provided.