Capturing camera parameters within the URL #334
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
src/utils/url-utils.ts
Outdated
| new URLSearchParams(window.location.search) | ||
| ); | ||
| const { longitude, latitude, pitch, bearing, zoom } = viewState.main; | ||
| setSearchParams( |
There was a problem hiding this comment.
I don't like having a state setter outside of react. I was about returning some ready to use object and set it in the component.
We can have it here but need to make a TSDoc comments anyway.
There was a problem hiding this comment.
Done
src/utils/url-utils.ts
Outdated
| @@ -57,3 +57,35 @@ const prepareTilesetUrl = (parsedUrl) => { | |||
| .concat("layers/0"); | |||
| return `${parsedUrl.origin}${replacedPathName}${parsedUrl.search}`; | |||
| }; | |||
|
|
|||
| export const viewStateToUrlParams = (viewState, setSearchParams) => { | |||
There was a problem hiding this comment.
Add TSDoc and tests for new functions
There was a problem hiding this comment.
Done
src/utils/url-utils.ts
Outdated
| ); | ||
| }; | ||
|
|
||
| export const urlParamsToViewState = (viewState, setStateUrlViewStateParams) => { |
There was a problem hiding this comment.
Done
src/utils/url-utils.ts
Outdated
| urlViewStateParams[viewStateParam[0]] = parseFloat(viewStateParam[1]); | ||
| } | ||
| } | ||
| setStateUrlViewStateParams(urlViewStateParams); |
There was a problem hiding this comment.
Ditto: I prefer returning a value and setting the state in the component.
There was a problem hiding this comment.
Done
maxkuznetsov-actionengine
deleted the
feature/ES-672_camera_params_url
branch
No description provided.