Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(arcgis): auth UI #326

Merged
merged 10 commits into from
Dec 11, 2023
Merged

feat(arcgis): auth UI #326

merged 10 commits into from
Dec 11, 2023

Conversation

mspivak-actionengine
Copy link
Collaborator

No description provided.

belom88
belom88 requested changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@belom88 belom88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use for the commit message "feat(arcgis): auth UI"

src/app.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/action-icon-button/action-icon-button.tsx Outdated Show resolved Hide resolved
src/components/action-icon-button/action-icon-button.tsx Outdated Show resolved Hide resolved
src/components/action-icon-button/action-icon-button.tsx Outdated Show resolved Hide resolved
src/components/action-icon-button/action-icon-button.tsx Outdated Show resolved Hide resolved
src/components/action-icon-button/action-icon-button.tsx Outdated Show resolved Hide resolved
@mspivak-actionengine mspivak-actionengine changed the title feat(arcgis): arcgis UI feat(arcgis): auth UI Dec 6, 2023
@mspivak-actionengine mspivak-actionengine marked this pull request as draft December 7, 2023 09:32
@mspivak-actionengine mspivak-actionengine marked this pull request as ready for review December 7, 2023 09:49
belom88
belom88 requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@belom88 belom88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too large gap between "Insert scene" and splitter:
image
Too large gap between "Import" and the panel bottom:
image

src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/app.tsx Outdated Show resolved Hide resolved
src/components/layers-panel/layers-control-panel.tsx Outdated Show resolved Hide resolved
src/components/layers-panel/layers-control-panel.tsx Outdated Show resolved Hide resolved
src/components/layers-panel/layers-control-panel.tsx Outdated Show resolved Hide resolved
belom88
belom88 requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@belom88 belom88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary scroll always seen:
image

src/components/logout-button/logout-button.tsx Outdated Show resolved Hide resolved
src/components/action-icon-button/action-icon-button.tsx Outdated Show resolved Hide resolved
src/components/action-icon-button/action-icon-button.tsx Outdated Show resolved Hide resolved
@mspivak-actionengine mspivak-actionengine merged commit baaf749 into ms/arcgis-connect Dec 11, 2023
2 checks passed
@mspivak-actionengine mspivak-actionengine deleted the ms/arcgis-auth-ui branch December 11, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belom88 belom88 belom88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mspivak-actionengine @belom88