Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: controls on arcgis map #315

Merged
merged 6 commits into from
Nov 23, 2023
Merged

fix: controls on arcgis map #315

merged 6 commits into from
Nov 23, 2023

Conversation

unclFedor
Copy link
Collaborator

also added picking up info

@aws-amplify-us-east-2 AWS Amplify (us-east-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-315.d3nof3l3x2sso4.amplifyapp.com

@unclFedor unclFedor requested a review from belom88 November 21, 2023 15:59
belom88
belom88 requested changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@belom88 belom88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a file in utils to put code shared between ArcGisWrapper and DeckGlWrapper. For hooks we can create a custom hook to share in those components.

src/hooks/use-arcgis-hook/use-arcgis-hook.ts Outdated Show resolved Hide resolved
src/hooks/use-arcgis-hook/use-arcgis-hook.ts Show resolved Hide resolved
src/components/map-control-panel/map-control-panel.tsx Outdated Show resolved Hide resolved
src/pages/viewer-app/viewer-app.tsx Outdated Show resolved Hide resolved
@unclFedor unclFedor merged commit fea25ee into basemaps Nov 23, 2023
3 checks passed
@unclFedor unclFedor deleted the is/fix_arcgis_controls branch November 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belom88 belom88 belom88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unclFedor @belom88