Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typescript #269

Merged
merged 22 commits into from
May 3, 2024
Merged

chore: typescript #269

merged 22 commits into from
May 3, 2024

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Apr 26, 2024 •
edited
Loading

Closes #242, #244

  • Adds typescript types to all library code
  • Upgrades build tools to latest version of ocular (esbuild, removes webpack/babel)
  • Bundles with esbuild (not fully functioning)
  • Switch to vite in getting-started
  • Update lint rules
  • Added test coverage
  • Added test-ci and github action
  • Added browser tests

@chrisgervang
Copy link
Collaborator Author

chrisgervang commented Apr 26, 2024 •
edited
Loading

@Pessimistress have any tips for getting my linter to work with TS?

Actually, I think I got it.

@chrisgervang
chore(core) fix linter
adcf800 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore(core) more types
ee73cfc 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore(core) more types
6292d9d 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore(core) more types
b2dbe12 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore(core) fix ESM index imports
7603382 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore(core) fix test types
4c4a5bf 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore(react) add types
2b4ee08 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang chrisgervang marked this pull request as ready for review May 1, 2024 00:46
@chrisgervang
chore(react) add ts eslint ts rules
85b7f58 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: update gh test action
76b0292 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: remove gl
c8c0e6a 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: add test-ci
ae8cfdc 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang chrisgervang changed the title chore(core) most files ported to typescript chore: typescript May 1, 2024
@chrisgervang
chore: fix most strict type checks
3c6fbc2 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: dont build examples, fix lint
2e659d2 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: work on test imports
fd7a1ed 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: export types and fix get-started
4fea473 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: remove webpack and babel
d9d4b84 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: work on standalone bundle
3e1f145 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: ignore root deps
3c1e8d0 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: fix test runner (but not all tests)
7a1df84 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: fix tests
6a5a63a 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang
chore: coverage
2b8ad0e 
Signed-off-by: Chris Gervang <[email protected]>
@chrisgervang chrisgervang merged commit bb024d8 into master May 3, 2024
1 check passed
@chrisgervang chrisgervang deleted the chr/typescript branch May 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] [Small] esbuild to replace webpack
1 participant
@chrisgervang