Allow 0s for maxCacheSize and maxCacheByteSize

By allowing 0s for maxCacheSize and maxCacheByteSize, the cache of TileLayer can be disabled.
visgl · Sep 13, 2024 · 6501da8 · 6501da8
1 parent c20af82
commit 6501da8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/modules/geo-layers/src/tileset-2d/tileset-2d.ts b/modules/geo-layers/src/tileset-2d/tileset-2d.ts
@@ -147,7 +147,7 @@ export class Tileset2D {
 
     this.onTileLoad = tile => {
       this.opts.onTileLoad?.(tile);
-      if (this.opts.maxCacheByteSize) {
+      if (this.opts.maxCacheByteSize != null) {
         this._cacheByteSize += tile.byteLength;
         this._resizeCache();
       }
@@ -469,10 +469,10 @@ export class Tileset2D {
     const {_cache, opts} = this;
 
     const maxCacheSize =
-      opts.maxCacheSize ||
+      opts.maxCacheSize ??
       // @ts-expect-error called only when selectedTiles is initialized
       (opts.maxCacheByteSize ? Infinity : DEFAULT_CACHE_SCALE * this.selectedTiles.length);
-    const maxCacheByteSize = opts.maxCacheByteSize || Infinity;
+    const maxCacheByteSize = opts.maxCacheByteSize ?? Infinity;
 
     const overflown = _cache.size > maxCacheSize || this._cacheByteSize > maxCacheByteSize;