Adding Turin support and updating ASK CN #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Turin support for certificate fetching. A recent update to the CA certificates changed the name of the ASK common name to SEV-<processor name>, we added that option to our parser so that certificate verfication still works. Signed-off-by: DGonzalezVillal <[email protected]>
tylerfanelli
reviewed
Nov 7, 2024
| @@ -277,7 +277,7 @@ mod attestation { | |||
| { | |||
| match val.to_lowercase() { | |||
| x if x.contains("ark") => Ok(CertType::ARK), | |||
| x if x.contains("ask") => Ok(CertType::ASK), | |||
| x if x.contains("ask") | x.contains("sev") => Ok(CertType::ASK), | |||
There was a problem hiding this comment.
@tylerfanelli This was an addition due to a change introduced to the KDS. Formerly the Common name of the ASK contained "ASK", now it contains "SEV-", so we adjusted it to be backward-compatible.
There was a problem hiding this comment.
Understood, thanks for clearing that up.
tylerfanelli
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Turin support for certificate fetching.
A recent update to the CA certificates changed the name of the ASK common name to SEV-, we added that option to our parser so that certificate verification still works.