Fetch: Adding status check to HTTP response #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGonzalezVillal
requested changes
Feb 15, 2024
larrydewey
force-pushed
the
37-validate-fetch
branch
from
e91efa8 to
a7216b9
Compare
larrydewey
force-pushed
the
37-validate-fetch
branch
2 times, most recently
from
c2c478f to
8e1ddaa
Compare
Previously to this fix (37), URL requests would write the contents of "404 Not Found" to the certificate being requested. This adds a simple check to make sure the certificate was successfully pulled before writing it. Signed-off-by: Larry Dewey <[email protected]>
larrydewey
force-pushed
the
37-validate-fetch
branch
from
8e1ddaa to
e070526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously to this fix #37 , URL requests would write the contents of "404 Not Found" to the certificate being requested. This adds a simple check to make sure the certificate was successfully pulled before writing it.