Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous HL7 improvements #6

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Miscellaneous HL7 improvements #6

merged 4 commits into from
Feb 26, 2019

Conversation

ransford
Copy link
Contributor

Several improvements to HL7 handling:

  • Use PRT-16 instead of PRT-10 for a generic identifier string. PRT-10 was a relic of an earlier attempt to make use of UDI first. That will happen in another branch shortly.
  • Loop over a list of HL7 message queries to match against a message instead of using a switch statement. This will pave the way for Configurable field fetching #3.
  • Also, the HL7 decoder now requires initialization via buildHL7Queries() (name may change).
  • Remove some unnecessary stringification to simplify packet header peeking.

@ransford
HL7: look in PRT-16 rather than PRT-10 by default
58e45d1 
PRT-10 nominally holds a UDI that can be used as a key to look up important
device details in a public database; PRT-16 is more likely to be the freeform
identifier string we want.
@ransford
use a list of precompiled queries, not a set of vars
6e9adfc 
will help with #3
@ransford
clean up
d95265a
@ransford ransford added bug Something isn't working HL7 labels Feb 23, 2019
@ransford
Copy link
Contributor Author

I added the bug label because the PRT-10 vs. PRT-16 thing was obviously unintentional.

@ransford ransford requested a review from ukrutt February 23, 2019 08:00
@ransford ransford added this to the 1.0.1 milestone Feb 24, 2019
@ransford
Copy link
Contributor Author

Review note: I started a new PR #8 that scratches these itches more. Once I added buildHL7Queries(), it became clear that it made sense to use a stateful object.

@ransford ransford removed the request for review from ukrutt February 26, 2019 07:00
@ransford ransford deleted the feature/hl7-udi branch February 26, 2019 07:01
@ransford ransford merged commit 1201cdf into develop Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working HL7
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
1 participant
@ransford