Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and broken links #565

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Fix typo and broken links #565

merged 2 commits into from
Dec 6, 2021

Conversation

2ykwang
Copy link
Contributor

@2ykwang 2ykwang commented Dec 2, 2021 •
edited
Loading

Description

Fixed some broken links in README.md, and fixed typos in CONTRIBUTING.md.

Motivation and Context

Screenshots (if appropriate):

Steps to reproduce (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires documentation updates.
  • I have updated the documentation accordingly.
  • My change requires dependencies updates.
  • I have updated the dependencies accordingly.

fjsj
fjsj reviewed Dec 6, 2021
View reviewed changes
README.md Outdated
- [WhiteNoise](http://whitenoise.evans.io/en/stable/) with [brotlipy](https://github.com/python-hyper/brotlipy), for efficient static files serving
- [prospector](https://prospector.landscape.io/en/master/) and [ESLint](https://eslint.org/) with [pre-commit](http://pre-commit.com/) for automated quality assurance (does not replace proper testing!)
- [Celery](https://docs.celeryproject.org/), for background worker tasks
- [WhiteNoise](http://whitenoise.evans.io/en/stable/) with [brotlipy](https://github.com/python-hyper/brotlicffi), for efficient static files serving
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're still using the old brotli: https://pypi.org/project/brotlipy/
We'll change that soon, once we fix #561

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

fjsj
fjsj requested changes Dec 6, 2021
View reviewed changes
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall looking good. The only issue I see is the brotli lib.

@2ykwang 2ykwang requested a review from fjsj December 6, 2021 17:19
fjsj
fjsj approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@fjsj fjsj merged commit ff62d93 into vintasoftware:master Dec 6, 2021
@2ykwang 2ykwang deleted the patch-1 branch December 6, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjsj fjsj fjsj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2ykwang @fjsj