Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes README instructions for running tests #157

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

filipeximenes
Copy link
Contributor

poetry run pytest on a fresh install would not work and there were no instructions pointing that you need to set OPENAI_API_KEY on in .env.tests for the tests to pass. This PRs adds instructions to create a .env.tests file.

@filipeximenes filipeximenes requested review from fjsj and pamella August 6, 2024 13:54
CONTRIBUTING.md Outdated
@@ -97,19 +104,21 @@ poetry run mkdocs serve
## Release

!!! info
The backend and the frontend are versioned together, that is, they should have the same version number.
The backend and the frontend are versioned together, that is, they should have the same version number.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change because it breaks the formatting.

Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but please check Pam's comment.

@filipeximenes filipeximenes requested review from fjsj and pamella August 6, 2024 14:14
Copy link
Collaborator

@pamella pamella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipeximenes filipeximenes merged commit 6cb84c5 into main Aug 6, 2024
18 checks passed
@filipeximenes filipeximenes deleted the setup-fixes branch August 6, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants