Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow offsets in pyopencl arrays #16

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow offsets in pyopencl arrays #16

wants to merge 2 commits into from

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Mar 15, 2022

No description provided.

@vincefn
Copy link
Owner

vincefn commented Mar 19, 2022

Thanks for the PR. I never use offsets = this corresponds to array pointing to memory allocations with an offset ?

Could you add a corresponding unit test ? Nothing as systematic as the current test, but e.g. like the old version of test like https://github.com/vincefn/pyvkfft/blob/d5eb898164b3a36c2d1b8fc2ccfadfcec2b855cc/test/test_opencl.py ?

@isuruf isuruf marked this pull request as draft March 23, 2022 21:30
@isuruf
Copy link
Contributor Author

isuruf commented Mar 23, 2022

I'm marking this as draft as the test is not working. I'll get back to this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isuruf @vincefn