Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui_running may not be set for neovim #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthew-brett
Copy link

See discussion of "gui_running" and neovim at
neovim/neovim#3646 and related fix at
junegunn/goyo.vim@8faad54

Without this fix, running Neovim in GUI mode via neovim-dot-app, I get
messages of form:

Color name or number not recognized: ctermfg=#b1d631

See discussion of "gui_running" and neovim at
neovim/neovim#3646 and related fix at
junegunn/goyo.vim@8faad54

Without this fix, running Neovim in GUI mode via neovim-dot-app, I get
messages of form:

Color name or number not recognized: ctermfg=#b1d631
@alerque
Copy link
Member

alerque commented May 18, 2019

I've been running Neovim in both GUI and terminal true color environments for years along with this plugin and haven't encountered this. Under what circumstances is this a problem? In other words how can I replicate the scenario this effects?

@matthew-brett
Copy link
Author

From the discussion linked, it looks like gui_running may or may not be available at startup, so I guess that means this error will happen only in some cases of a GUI app.

I'm running Neovim via https://github.com/rogual/neovim-dot-app with the mustang color scheme. But I get the same effect on one other colorscheme I tried.

I don't know Vim colors very well, but I thought that it was always true that a ctermfg= followed by a #RGB is going to give an error, so I guess this change is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants