-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configuration for typos-rs-npm and update formatting scripts #1994
Conversation
Neat ✨
What GitHub token? What is it used for?
Can we set I think we should add Instead of adding it to the |
3b5e7b2
to
bcd5101
Compare
@brillout My reasoning to expose the github_token was to reduce the odds of being ratelimt which could disrupt the github action workflow when trying to download typos package from github. I do not think it is possible to select the directory for typos to spell check. There is only ways to exclude files in _typos.toml file. And in my current changes I have added a new github action for typos |
I see. Yes, I guess we can add it publicly for now and add it privately if it's an issue to have it public. I guess we can always generate a new one? The PR LGTM. The only thing is that the CI seems to be failing, ideas why? It seems like it doesn't work on windows? |
@brillout As of right now I do not know why pnpm is stuck on windows. |
Since we have |
I don't have a windows machine to try it out. Feel free to push experimental commits in this PR to see what causes the CI to hang. |
Let's close in favor of tracking: |
Let's re-open (hopefully soon) after one of these two resolves. |
I have add the spell checker as you requested. I would like to know would you like me to expose the Github_Token to the workflows? What other configurations would like done to the typos?
#1943