Merge pull request #580 from forbesjo/null-check-mediasource

Added an extra null check for mediaSource
videojs · Mar 4, 2016 · b12ba42 · b12ba42
2 parents 6a9433a + fe517c0
commit b12ba42
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/videojs-hls.js b/src/videojs-hls.js
@@ -892,6 +892,7 @@ var filterBufferedRanges = function(predicate) {
     // report a fully empty buffer until SourceBuffers have been created
     // which is after a segment has been loaded and transmuxed.
     if (!this.mediaSource ||
+        !this.mediaSource.mediaSource_ ||
         !this.mediaSource.mediaSource_.sourceBuffers.length) {
       return videojs.createTimeRanges([]);
     }

diff --git a/test/videojs-hls_test.js b/test/videojs-hls_test.js
@@ -736,6 +736,13 @@ test('always returns an empty buffered region when there are no SourceBuffers',
   // Simulate the condition with no source buffers
   player.hls.mediaSource.mediaSource_.sourceBuffers = [];
 
+  equal(player.tech_.hls.findBufferedRange_().length,
+        0,
+        'empty TimeRanges returned');
+
+  // Simulate the condition with no media source
+  player.hls.mediaSource.mediaSource_ = undefined;
+
   equal(player.tech_.hls.findBufferedRange_().length,
         0,
         'empty TimeRanges returned');