Fix seeking into and over multiple EXT-X-GAP segments #6988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix an issue where the gap-controller would not skip over buffer holes produced by EXT-X-GAP segments.
Why is this Pull Request needed?
getFwdBufferInfoAtPoswas not properly stepping over EXT-X-GAP segments which prevented them from being re-added to the fragment tracker._trySkipBufferHolein gap-controller depends on being able to step through gap segments in the tracker to skip over large buffer holes.Are there any points in the code the reviewer needs to double check?
Additional changes will prevent skipping over a hole when an earlier audio or main segment is being loaded or a variant playlist is being loaded.
Resolves issues:
Fixes #6814
Checklist