Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exclude to not call MoveNext past end of sequence #145

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

viceroypenguin
Copy link
Owner

@viceroypenguin viceroypenguin commented Jan 23, 2023

Based on morelinq/MoreLINQ#692, however this PR uses simpler evaluation of the enumeration; benchmarking shows that complex code is not actually faster.

@codecov-commenter
Copy link

Codecov Report

Base: 87.19% // Head: 87.19% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (df6d5c2) compared to base (6ce4733).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   87.19%   87.19%   -0.01%     
==========================================
  Files         190      190              
  Lines        5124     5122       -2     
  Branches     1190     1189       -1     
==========================================
- Hits         4468     4466       -2     
  Misses        359      359              
  Partials      297      297              
Impacted Files Coverage Δ
Source/SuperLinq/Exclude.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viceroypenguin viceroypenguin merged commit 500b3d1 into master Jan 23, 2023
@viceroypenguin viceroypenguin deleted the exclude-movenext branch January 23, 2023 03:08
@viceroypenguin viceroypenguin added this to the 4.7.0 milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants