Style, accessibility, and performance improvements

vibecamp · Nov 10, 2023 · f133d57 · f133d57
1 parent 2af8807
commit f133d57
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 12 deletions.
diff --git a/front-end/public/index.html b/front-end/public/index.html
@@ -1,10 +1,11 @@
+<!DOCTYPE html>
 <html lang="en">
 
 <head>
     <title>My Vibecamp</title>
     <meta name="description" content="Let's vibe, y'all">
 
-    <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/leaflet.css" />
+    <!-- <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/leaflet.css" /> -->
 
     <link rel="manifest" href="/manifest.json" />
     <link rel="icon" href="/vibecamp-squircle.png" />

diff --git a/front-end/src/components/Login.tsx b/front-end/src/components/Login.tsx
@@ -64,7 +64,7 @@ export default observer(() => {
             <Col padding={20}>
                 <Stripes position='top-left' />
 
-                <img src="vibecamp.png" className='logo' />
+                <img src="vibecamp.png" className='logo' alt='Vibecamp logo' />
 
                 <Spacer size={24} />
 
@@ -86,18 +86,14 @@ export default observer(() => {
                     {...fieldToProps(loginForm.fields.password)}
                 />
 
-                {loginOrSignup.state.kind === 'error' &&
-                <>
-                </>}
-
                 <Spacer size={8} />
 
                 <ErrorMessage
                     error={
                         loginOrSignup.state.kind !== 'error' ? undefined :
-                            typeof loginOrSignup.state.error === 'string'? loginOrSignup.state.error :
+                            typeof loginOrSignup.state.error === 'string' ? loginOrSignup.state.error :
                                 DEFAULT_FORM_ERROR
-                    }/>
+                    } />
 
                 <Spacer size={24} />
 

diff --git a/front-end/src/components/Tickets.tsx b/front-end/src/components/Tickets.tsx
@@ -43,7 +43,7 @@ if (awaitingPurchaseRecord) {
 export default observer(() => {
     const state = useObservableState({
         code: '',
-        purchaseModalState: 'none' as 'none' | 'selection' | 'payment'
+        purchaseModalState: 'selection' as 'none' | 'selection' | 'payment'
     })
 
     const closePurchaseModal = useStable(() => () => {
@@ -69,7 +69,7 @@ export default observer(() => {
     }, { lazy: true })
 
     const stripeOptions = useRequest(async () => {
-        if (Object.values(purchaseFormState.purchases).some(count => count > 0)) {
+        if (Store.loggedIn && Object.values(purchaseFormState.purchases).some(count => count > 0)) {
             const { response } = await vibefetch(
                 Store.jwt,
                 '/purchase/create-intent',

diff --git a/front-end/src/components/core/Stripes.scss b/front-end/src/components/core/Stripes.scss
@@ -32,12 +32,12 @@
         }
 
         &.bottom-right {
-            bottom: 50;
+            bottom: 50px;
             right: -50vw;
             transform: scale(-1) rotate(-20deg);
         }
         &.top-left {
-            top: 0;
+            top: 0px;
             left: -50vw;
             transform: rotate(-20deg);
         }