comments

module/module.go

@@ -175,7 +175,8 @@ type peerResourceState struct {
 
 // Module represents an external resource module that services components/services.
 type Module struct {
-	// The name of the module as per the robot config.
+	// The name of the module as per the robot config. This value is communicated via the
+	// `VIAM_MODULE_NAME` env var.
 	name string
 
 	shutdownCtx             context.Context

module/testmodule/main.go

@@ -108,10 +108,8 @@ func newHelper(
 	ctx context.Context, deps resource.Dependencies, conf resource.Config, logger logging.Logger,
 ) (resource.Resource, error) {
 	var dependsOnSensor sensor.Sensor
-	for _, resObj := range deps {
-		if resSensor, ok := resObj.(sensor.Sensor); ok {
-			dependsOnSensor = resSensor
-		}
+	if len(conf.DependsOn) > 0 {
+		dependsOnSensor, err := sensor.FromDependencies(deps, conf.DependsOn[0])
 	}
 
 	if len(deps) > 0 && dependsOnSensor == nil {

robot/client/client_options.go

@@ -59,7 +59,7 @@ func newFuncRobotClientOption(f func(*robotClientOpts)) *funcRobotClientOption {
 }
 
 // WithModName attaches a unary interceptor that attaches the module name for each outgoing gRPC
-// request.
+// request. Should only be used in Viam module library code.
 func WithModName(modName string) RobotClientOption {
 	return newFuncRobotClientOption(func(o *robotClientOpts) {
 		o.modName = modName