Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-8292] Create Single App Connection and Use for Net Appender and Restart Checker #4746

Merged
merged 52 commits into from
Jan 29, 2025
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
09186d8
barely stub out new connection wrapper
bashar-515 Jan 23, 2025
e18211c
checkpoint
bashar-515 Jan 24, 2025
1306520
repeatedly retry connecting to App
bashar-515 Jan 27, 2025
5e5a791
no longer store initial error
bashar-515 Jan 27, 2025
7543b72
lint
bashar-515 Jan 27, 2025
b333e48
lint again
bashar-515 Jan 27, 2025
8827cd4
remove TODO comment
bashar-515 Jan 27, 2025
67d8e55
lint
bashar-515 Jan 27, 2025
1394587
log error
bashar-515 Jan 27, 2025
88e576b
return error
bashar-515 Jan 27, 2025
c9d46a9
lint
bashar-515 Jan 27, 2025
a974c16
use sublogger
bashar-515 Jan 27, 2025
1fd26c1
create context.Context within NewAppConn()
bashar-515 Jan 27, 2025
0511a68
use context.Context passed in as function parameter in repeated dials…
bashar-515 Jan 27, 2025
b87a1b5
no longer store error
bashar-515 Jan 27, 2025
5c4f7d3
always dial again
bashar-515 Jan 27, 2025
c4799cf
rename logger
bashar-515 Jan 27, 2025
11aa86f
add TODO comment
bashar-515 Jan 27, 2025
92ceb64
use unified connection in RestartChecker
bashar-515 Jan 27, 2025
a8a5af3
remove context.Context
bashar-515 Jan 27, 2025
1baabf6
lint
bashar-515 Jan 27, 2025
eb11c9e
check parent context
bashar-515 Jan 27, 2025
6f3f163
check parent context
bashar-515 Jan 27, 2025
a3b9956
restore web/server/restart_checker.go file
bashar-515 Jan 28, 2025
6ecf9ef
revert to checkpoint
bashar-515 Jan 28, 2025
6303b44
create connection to App before checking cloud config
bashar-515 Jan 28, 2025
c8c1b5d
refactor error conditions
bashar-515 Jan 28, 2025
43d718f
defer context cancel and eliminate race condition
bashar-515 Jan 28, 2025
1963013
lint
bashar-515 Jan 28, 2025
5e2b24b
release lock sooner
bashar-515 Jan 28, 2025
59101de
use stoppable workers
bashar-515 Jan 28, 2025
e2a592e
add comment to Close()
bashar-515 Jan 28, 2025
c626935
lint
bashar-515 Jan 28, 2025
51a9b3d
make comments more concise
bashar-515 Jan 28, 2025
2e9033b
only stop stoppable workers if non-nil
bashar-515 Jan 28, 2025
31dee57
change spacing
bashar-515 Jan 28, 2025
f1615a2
rephrase comments
bashar-515 Jan 28, 2025
f035a59
lint
bashar-515 Jan 28, 2025
93b7314
create connection to app without checking conditions
bashar-515 Jan 28, 2025
48dc67b
check for non-nil cloud config before creating connection to App
bashar-515 Jan 29, 2025
f0c8f07
use global connection to App in restart checker
bashar-515 Jan 29, 2025
40e87cf
clean up code
bashar-515 Jan 29, 2025
3ab3a53
lint
bashar-515 Jan 29, 2025
ded9d43
add to server connection to App
bashar-515 Jan 29, 2025
ff6953e
no longer check if error when intially dialing is due to time out
bashar-515 Jan 29, 2025
3da6860
use Debugw()
bashar-515 Jan 29, 2025
8f67114
lint
bashar-515 Jan 29, 2025
725d4d9
comment that the connection to App can be nil
bashar-515 Jan 29, 2025
24ba32f
only acquire lock if dial succeeds
bashar-515 Jan 29, 2025
728d692
lint
bashar-515 Jan 29, 2025
78fa924
remove comment from final return statment in AppConn constructor
bashar-515 Jan 29, 2025
b477b5a
remove TODO comment
bashar-515 Jan 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove TODO comment
bashar-515 committed Jan 29, 2025
commit b477b5a5e383911cf99f8b06b3bac97d6fe57d89
1 change: 0 additions & 1 deletion logging/net_appender.go
Original file line number Diff line number Diff line change
@@ -406,7 +406,6 @@ func (w *remoteLogWriterGRPC) write(ctx context.Context, logs []*commonpb.LogEnt
return nil
}

// TODO(RSDK-8292): [qu] do we need this anymore?
func (w *remoteLogWriterGRPC) getOrCreateClient(ctx context.Context) (apppb.RobotServiceClient, error) {
w.clientMutex.Lock()
defer w.clientMutex.Unlock()