subtask: fixing the literal-type constraint in the message prop for Input component
#613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay the error message below the input as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
working on APP-6609 of removing restricted text input across App and instead of the toggle to show the error message, we want to show the error message below the Input. see comment thread here. While working on this, I ran into errors due to the
messageprop in theInputcomponent being restricted to an empty string. This fix should ensure that validation errors are displayed as intended in the UIChanges
updated
export let messageto allow dynamic error message strings instead of being constrained to an empty literal type.