Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-3050: Add fusionauth instructions #3894

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DOCS-3050: Add fusionauth instructions #3894

wants to merge 2 commits into from
+157 −4

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Jan 22, 2025 •
edited
Loading

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 22, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2025 •
edited
Loading

✅ Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit d294b8b
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67916f843c53c500080aa58a
😎 Deploy Preview https://deploy-preview-3894--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 35 (🟢 up 6 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@npentrel npentrel force-pushed the fusionauth branch 2 times, most recently from 2d4e3c7 to 06bb684 Compare January 22, 2025 21:52
@npentrel npentrel requested a review from maxhorowitz January 22, 2025 21:55
@viambot
Copy link
Member

viambot commented Jan 22, 2025

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3894

@maxhorowitz
Copy link
Member

1. logo-path --> --logo-path

Screenshot 2025-01-22 at 5 59 12 PM

2. Maybe we can add an example with more than one URL as a comma-separated list for an argument?

Not sure where this would go ... maybe the "Click to view more information about arguments." area?

3. We also added the option to delete, should this be included too?

viam organization auth-service oauth-app delete

maxhorowitz
maxhorowitz requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@maxhorowitz maxhorowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super duper clear docs very happy with how this is turning out !

3 main comments - and with fresh eyes tomorrow will see if I can find anything else. Thanks again - I'll check back tomorrow morning on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhorowitz maxhorowitz maxhorowitz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @viambot @maxhorowitz