Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing link forwarding #3886

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix missing link forwarding #3886

merged 3 commits into from
Jan 24, 2025

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Jan 21, 2025 •
edited
Loading

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 21, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 788f1d4
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67911a2a05e48100087dbc72
😎 Deploy Preview https://deploy-preview-3886--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 24 (🟢 up 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@npentrel npentrel force-pushed the checkv3 branch 3 times, most recently from 8bf7578 to 2567c26 Compare January 21, 2025 13:41
@npentrel npentrel closed this Jan 21, 2025
@npentrel npentrel deleted the checkv3 branch January 21, 2025 17:14
@npentrel npentrel restored the checkv3 branch January 21, 2025 17:15
@npentrel npentrel reopened this Jan 21, 2025
@npentrel npentrel changed the title Checkv3 Fix missing link forwarding Jan 21, 2025
@viambot
Copy link
Member

viambot commented Jan 22, 2025

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3886

sguequierre
sguequierre approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@sguequierre sguequierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@npentrel npentrel merged commit b377482 into viamrobotics:main Jan 24, 2025
13 checks passed
@npentrel npentrel deleted the checkv3 branch January 24, 2025 20:44
@github-actions GitHub Actions
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguequierre sguequierre sguequierre approved these changes

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @viambot @sguequierre