[RSDK-9619] Add API for Discover Service and GetModelsFromModules #611
+3,213
−556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnN193
added
the
ready-for-protos
JohnN193
commented
Dec 31, 2024
|
|
||
| message DiscoverResourcesResponse { | ||
| // list of ComponentConfigs that describe the components found by a discover service. Can be used with UpdateRobotPart. | ||
| repeated app.v1.ComponentConfig discovery = 1; |
There was a problem hiding this comment.
just realized this should prob be called discoveries or something similar/plural
proto/viam/robot/v1/robot.proto
Outdated
| message GetModelsFromModulesRequest {} | ||
|
|
||
| message GetModelsFromModulesResponse { | ||
| repeated ModuleModel model = 1; |
There was a problem hiding this comment.
also perhaps models?
martha-johnston
approved these changes
Jan 6, 2025
JohnN193
removed
the
ready-for-protos
JohnN193
added
the
ready-for-protos
JohnN193
removed
the
ready-for-protos
randhid
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-9619