Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giraffe paired end fragment length #4438

Closed
wants to merge 2 commits into from

Conversation

xchang1
Copy link
Contributor

@xchang1 xchang1 commented Nov 6, 2024

Changelog Entry

To be copied to the draft changelog by merger:

  • Change giraffe's measurement of distance between pairs of reads to measure between the inner edges plus the lengths of the reads

Description

This might address #4434

… between the inner edges plus the lengths of the reads
@xchang1
Copy link
Contributor Author

xchang1 commented Nov 6, 2024

I haven't tested this yet

@adamnovak
Copy link
Member

@xchang1 Have you tested/will you test this?

@xchang1
Copy link
Contributor Author

xchang1 commented Jan 29, 2025

Sorry, I forgot about this. I will test it

@xchang1
Copy link
Contributor Author

xchang1 commented Jan 30, 2025

Ok I tested it and it's a bit worse. Weird. Maybe we just optimized for the underestimate.
But I don't really want to go hunting this down now and it looks like the issue that started this is quiet so I'm going to close this

@xchang1 xchang1 closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants