support to config the version white list #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 63.30% 63.41% +0.11%
==========================================
Files 8 8
Lines 2382 2392 +10
==========================================
+ Hits 1508 1517 +9
- Misses 748 750 +2
+ Partials 126 125 -1 ☔ View full report in Codecov by Sentry. |
Nicole00
force-pushed
the
version_white_list
branch
from
3dc491d to
f7522c1
Compare
|
why need user provide the version? |
HarrisChu
reviewed
Jan 3, 2024
connection.go
Outdated
| @@ -30,6 +30,7 @@ type connection struct { | |||
| sslConfig *tls.Config | |||
| useHTTP2 bool | |||
| httpHeader http.Header | |||
| version string | |||
There was a problem hiding this comment.
please run go fmt to make aligned
Yeah, this |
HarrisChu
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #299