-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scan method for ResultSet to scan the rows into the given slice (Part 1) #298
Conversation
some ci failures need to be deal due to the go version. |
@Nicole00 may I just removed the go versions |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
==========================================
- Coverage 63.41% 63.37% -0.05%
==========================================
Files 8 9 +1
Lines 2392 2452 +60
==========================================
+ Hits 1517 1554 +37
- Misses 750 768 +18
- Partials 125 130 +5 ☔ View full report in Codecov by Sentry. |
For now we can't remove the go version yet. Because it will confluence the users' usage when upgrade the nebula-go. |
ok, I will remove the usage of |
Update test.yaml
This reverts commit 2478f44.
@Nicole00 any other comments? |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#296
Description:
This PR includes changes in #297,
I add the first draft implementation for the API proposed in #296.
Some tasks need to be done, such as
But I raised this PR as a draft in case there are some potential concerns from your guys.
So feel free to leave some comments here.
Such as can we drop support for Go versions that
< 1.18
?cc @wey-gu @veezhang
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: