Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackbox SDF timing fixes #1566

Merged

Conversation

acomodi
Copy link
Collaborator

@acomodi acomodi commented Oct 6, 2020

Description

Summary of changes:

  1. Traverse through input and output pins of blackbox primitives and populate timing_arcs, Tsu, Thld, Tco in local netist_writer data structure.

  2. Store and output the correct reference clock ports in SDF writing.

Related Issue

SymbiFlow#537

Motivation and Context

There are multiple issues related to SDF writer for Blackbox primitive

  1. The primitives being modelled as Blackbox have combinational and sequential timings. In present --analysis code, BlackBox combinational and sequential timings are not getting populated

  2. Blackbox could have more than 1 reference clocks (e.g. Dual Port RAM). Current SDF generation does not handle timing checks w.r.t. specific clock. It uses a generic name "clk" to write out timing checks

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@acomodi
Copy link
Collaborator Author

acomodi commented Oct 6, 2020

@tpagarani FYI

@acomodi acomodi requested a review from vaughnbetz October 6, 2020 09:18
@acomodi acomodi changed the title Blackbox timing to upstream Blackbox SDF timing fixes Oct 6, 2020
@acomodi
Copy link
Collaborator Author

acomodi commented Oct 7, 2020

@vaughnbetz FYI

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just have some suggestions for additional comments on data structures and types.

@acomodi acomodi force-pushed the blackbox_timing_to_upstream branch from 578d570 to 5dc8e83 Compare October 7, 2020 16:22
@acomodi acomodi requested a review from vaughnbetz October 7, 2020 16:34
@vaughnbetz
Copy link
Contributor

Looks good to me. Go ahead and merge when CI finishes (or I will, but you can probably get it in faster if you merge yourself).

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@acomodi acomodi merged commit 9098cd1 into verilog-to-routing:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants