Implement Home page #219
Merged
Implement Home page #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Thanks @icetrust0212 I'll review it today |
aurelticot
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks for the PR @icetrust0212, really appreciate the work.
There are a few changes needed though, notably the Header is not behaving correctly anymore.
Please see my comments below.
aurelticot
requested changes
Apr 2, 2024
src/components/pages/HomeView.tsx
Outdated
| import { useIntl } from "react-intl"; | ||
| import HeroSection from "../organisms/HeroSection"; | ||
| import JoinWaitlist from "../organisms/JoinWaitlist"; | ||
| import LearnMore from "../organisms/LearnMore"; |
There was a problem hiding this comment.
We use barrel files in this repository. Could you add this component to the barrel file in organisms? Thanks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.