Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/19 badge related components #117

Merged
merged 8 commits into from
Feb 22, 2023
Merged

Feature/19 badge related components #117

merged 8 commits into from
Feb 22, 2023

Conversation

aurelticot
Copy link
Member

No description provided.

@aurelticot aurelticot self-assigned this Feb 17, 2023
This was linked to issues Feb 17, 2023
Add Badge honeycomb mosaic on Badge list page and Profile #70
Closed
Implement Badge related components #19
Closed
@aurelticot
update mock data with latest badge design
cb9b15c
@aurelticot
implement badge related components
ae81c29 
closes Implement Badge related components #19
@aurelticot
implement badge mosaic
55fca0a 
closes Add Badge honeycomb mosaic on Badge list page and Profile #70
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-117.d29a9kk5kl8bp0.amplifyapp.com

@aurelticot aurelticot marked this pull request as ready for review February 21, 2023 04:59
@aurelticot aurelticot marked this pull request as draft February 21, 2023 05:01
@aurelticot
Copy link
Member Author

Few points left behind, to be implemented in a subsequent PR:

  • Shadow under the badges in the Badges section of the profile has been disabled because of some render bugs
  • The honeycomb pattern underneath the Badges has not been implemented yet

@aurelticot aurelticot marked this pull request as ready for review February 21, 2023 06:28
nick-verida
nick-verida suggested changes Feb 21, 2023
View reviewed changes
Copy link

@nick-verida nick-verida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

yarn start gives me a black screen and the following error in the console

@nick-verida nick-verida self-requested a review February 21, 2023 22:31
nick-verida
nick-verida approved these changes Feb 21, 2023
View reviewed changes
Copy link

@nick-verida nick-verida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I think the Twitter and Facebook accounts should be linked when you click through the badges:
image

@aurelticot
Copy link
Member Author

Approved, but I think the Twitter and Facebook accounts should be linked when you click through the badges

Thanks.
I created an issue for the link #124.
Note that this PR was focus on the badge mosaic components, the badge details page has been implemented some time ago.

@aurelticot aurelticot merged commit 5847409 into develop Feb 22, 2023
@aurelticot aurelticot deleted the feature/19-badge-related-components branch February 22, 2023 00:45
@aurelticot aurelticot added this to the beta milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-verida nick-verida nick-verida approved these changes

Assignees

@aurelticot aurelticot

Labels
None yet
Projects
None yet
Milestone
1.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Add Badge honeycomb mosaic on Badge list page and Profile Implement Badge related components
3 participants
@aurelticot @nick-verida @cmcWebCode40