This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated home page UI and contents #112
base: develop
Are you sure you want to change the base?
updated home page UI and contents #112
Changes from 2 commits
cb69fc6
4e193a2
666128a
5f89ecc
446ffee
311321f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the "... Client SDK Javascript SDKs ...".
@nick-verida, what is the official name we should use while referring to the SDK(s)? We sometimes use "Verida Javascript Library", like in the API doc
My understanding is:
The Client SDK is available for 3 platforms with the following packages:
The SSO SDK is available through the following package:
Am I correct?
Should we standardise how we refer to them in the whole documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aurelticot depends on the context. In this case it was pretty deliberate because someone in the "getting started" phrase doesn't yet understand the distinction, and we want them to look at both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I still don't get the sentence in the doc. If the target is someone that doesn't yet understand the distinction, I find "... Client SDK Javascript SDKs ..." pretty confusing.
How about simply: "Implement the SDKs in your application"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like the image are clickable links.
@nick-verida all the other links/buttons in this page are with a box and linear gradient background, how about having a similar look? (noting it might too much)