Skip to content

Commit

Permalink
feat!: upgrade appVersion to 5.0.1 (#60)
Browse files Browse the repository at this point in the history
* feat: upgrade appVersion to 5.0.1

* update readme

* chore: fix trailing space

* Update values.yaml

* Update README.md
  • Loading branch information
juanpicado authored Apr 13, 2021
1 parent 35bd088 commit c6a2b3e
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ and their default values.
| `image.pullPolicy` | Image pull policy | `IfNotPresent` |
| `image.pullSecrets` | Image pull secrets | `[]` |
| `image.repository` | Verdaccio container image repository | `verdaccio/verdaccio` |
| `image.tag` | Verdaccio container image tag | `4.12.0` |
| `image.tag` | Verdaccio container image tag | `5.0.1` |
| `nodeSelector` | Node labels for pod assignment | `{}` |
| `tolerations` | List of node taints to tolerate | `[]` |
| `persistence.accessMode` | PVC Access Mode for Verdaccio volume | `ReadWriteOnce` |
Expand Down Expand Up @@ -174,10 +174,12 @@ $ helm install npm \
```

### Migrating chart 2.x -> 3.x

Due to some breaking changes in Selector Labels and Security Contexts in Chart `3.0.0` you will need to migrate when upgrading.

First off, the `securityContext.enabled` field has been removed.
In addition to this, `fsGroup` is not a valid Container Security Context field and has been migrated to the `podSecurityContext` instead.

```diff
# values.yaml
podSecurityContext:
Expand All @@ -191,3 +193,7 @@ podSecurityContext:
Secondly, the `apps.v1.Deployment.spec.selector` field is immutable and changes were made to Selector Labels which tries to update this.
To get around this, you will need to `kubectl delete deployment $deploymentName` before doing a `helm upgrade`
So long as your PVC is not destroyed, the new deployment will be rolled out with the same PVC as before and your data will remain intact.

### Migrating chart 3.x -> 4.x

Due the major release **Verdaccio 5** has some breaking changes to be aware of, please [read the migration guide here](https://verdaccio.org/blog/2021/04/14/verdaccio-5-migration-guide).
6 changes: 3 additions & 3 deletions charts/verdaccio/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v2
description: A lightweight private npm proxy registry (sinopia fork)
description: A lightweight private node.js proxy registry
name: verdaccio
version: 3.0.1
appVersion: 4.12.0
version: 4.0.0
appVersion: 5.0.1
home: https://verdaccio.org
icon: https://cdn.verdaccio.dev/logos/default.png
sources:
Expand Down
7 changes: 3 additions & 4 deletions charts/verdaccio/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image:
repository: verdaccio/verdaccio
tag: 4.12.0
tag: 5.0.1
pullPolicy: IfNotPresent
pullSecrets: []
# - dockerhub-secret
Expand Down Expand Up @@ -161,9 +161,8 @@ configMap: |
enabled: true
# log settings
logs:
- {type: stdout, format: pretty, level: http}
#- {type: file, path: verdaccio.log, level: info}
logs: {type: stdout, format: pretty, level: http}
# logs: {type: file, path: verdaccio.log, level: info}
persistence:
enabled: true
Expand Down

0 comments on commit c6a2b3e

Please sign in to comment.