Feat: existing secret (#100)

Co-authored-by: Loïc Antoine-Gombeaud <[email protected]>
verdaccio · Jun 7, 2022 · b8dda9a · b8dda9a
1 parent 9b1c809
commit b8dda9a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -119,6 +119,7 @@ and their default values.
 | `serviceAccount.name`              | Service account Name                                                             | none                           |
 | `extraEnvVars`                     | Define environment variables to be passed to the container                       | `[]`                           |
 | `secretEnvVars`                    | Define sensitive environment variables to be passed to the container             | `{}`                           |
+| `existingSecret`                   | Existing secret containing environment variables to be passed to the container   | `""`                           |
 | `extraInitContainers`              | Define additional initContainers to be added to the deployment                   | `[]`                           |
 | `securityContext`                  | Define Container Security Context                                                | `{runAsUser=10001}`            |
 | `podSecurityContext`               | Define Pod Security Context                                                      | `{fsGroup=101}`                |

diff --git a/charts/verdaccio/Chart.yaml b/charts/verdaccio/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 description: A lightweight private node.js proxy registry
 name: verdaccio
-version: 4.8.0
+version: 4.9.0
 appVersion: 5.5.0
 home: https://verdaccio.org
 icon: https://cdn.verdaccio.dev/logos/default.png

diff --git a/charts/verdaccio/templates/deployment.yaml b/charts/verdaccio/templates/deployment.yaml
@@ -42,10 +42,16 @@ spec:
         - name: {{ template "verdaccio.name" . }}
           image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
-          {{- if .Values.secretEnvVars }}
+          {{- if or .Values.secretEnvVars .Values.existingSecret }}
           envFrom:
+            {{- if .Values.secretEnvVars }}
             - secretRef:
                 name: {{ template "verdaccio.fullname" . }}-env
+            {{- end }}
+            {{- if .Values.existingSecret }}
+            - secretRef:
+                name: {{ .Values.existingSecret }}
+            {{- end }}
           {{- end }}
           ports:
             - containerPort: 4873

diff --git a/charts/verdaccio/values.yaml b/charts/verdaccio/values.yaml
@@ -115,6 +115,10 @@ secretEnvVars: {}
   # corp_artifactory: foo
   # npmjs: bar
 
+## Existing Secret
+## Existing secret containing environment variables to be passed to the container
+existingSecret: ""
+
 # Extra Init Containers - allows yaml definitions
 extraInitContainers: []