feat: boundaries #9634
Open
feat: boundaries #9634
+823
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NicholasLYang
force-pushed
the
nicholasyang/boundaries
branch
from
7cc741b to
42e3344
Compare
NicholasLYang
force-pushed
the
nicholasyang/boundaries
branch
from
53f55cf to
93929ce
Compare
chris-olszewski
requested changes
Jan 8, 2025
| async fn boundaries(&self) -> Result<Array<Diagnostic>, Error> { | ||
| match self.run.check_boundaries().await { | ||
| Ok(result) => { | ||
| result.emit(); |
There was a problem hiding this comment.
Out of scope for this PR, but this feels weird to me. What's the intended use of this info? Should it be output by default or gated behind a trace/debug level log?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a first pass at a boundaries implementation. We add a top level command
turbo boundariesthat checks your files for invalid imports. We currently check for:Testing Instructions
Added tests via
queryfor the three scenarios listed above.