Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #124 #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for #124 #125

wants to merge 1 commit into from

Conversation

jezzarax
Copy link

Updated version of circe to 0.9.0 to make vegas work in ammonite shell.

@jezzarax
Copy link
Author

I guess we need to wait for @aishfenton to release argus with updated circe version for the tests to be fixed.

@jasonmoore2k
Copy link

Any plans to complete this work and move up to circe 0.9.x?

@jasonmoore2k
Copy link

Sorry about that, I only noticed your last comment after I submitted mine. Is Argus a vital part of how Vegas works? If not, would removing that dependency be an option for upgrading circe?

@jezzarax
Copy link
Author

Yup, Argus seems quite important for Vegas, I see some activity in Argus repo, will check later if there were any relevant updates to help this PR.

@jasonmoore2k
Copy link

The only relevant update is the bumping of the circe version, yeah? This and other things are hitting master over there but not actually being released. Would it be difficult to reach out to @aishfenton to release it as-is to then pull the new version into Vegas?

My motivation is that I'm also trying to use Vegas with other packages that use circe 0.9.x and ideally would like no conflicts to work around.

@rgbkrk
Copy link
Collaborator

rgbkrk commented Jul 11, 2018

Hey we've gotten other maintainers on board (@oshikiri being one of them) -- would you like to revisit this + rebase? I'd love to see this work well in Ammonite and jupyter-scala. 😄

@dankolesnikov
Copy link

#156

Overview of the issue with circe 0.9.x..
@oshikiri @aishfenton how is the work with upgrading Argus to use scalameta going? Can I help?

@oshikiri
Copy link
Collaborator

@dankolesnikov I don't know about the progress...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants