Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update uint256 to 1.3.0 and decimal to 1.4.0 #11471

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jeremyletang
Copy link
Member

I've just noticed that both the uin256 and decimal package have had recent (ish) updates, and both recent release comes with performances improvement. The codebase relying heavily on both of these, updating them can only be beneficial.

@ze97286
Copy link
Contributor

ze97286 commented Jul 17, 2024

I've already had it in the upgrade to cometbft 1.0

@EVODelavega EVODelavega force-pushed the chore/update-nums-package branch from ae345c4 to 4a171a7 Compare July 18, 2024 09:01
@jeremyletang jeremyletang reopened this Jul 19, 2024
@jeremyletang
Copy link
Member Author

@ze97286 I had closed that but actually reopening because:

  • your PR updates uint256 to 1.2.4 instead of 1.3
  • it also update to decimal 1.4 but is innefective because of the replace directive which still resolve to the old branch of our fork

@jeremyletang jeremyletang force-pushed the chore/update-nums-package branch from 4a171a7 to b4038a0 Compare July 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

3 participants