-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate vAMM into market-sim #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/vamm
branch
3 times, most recently
from
June 17, 2024 14:31
28066c8
to
d1a01c2
Compare
daniel1302
reviewed
Jul 10, 2024
daniel1302
previously approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be good to merge. I have tested it in live environment(stagnet1) and all is working well. Here is a bots PR: vegaprotocol/research-bots#16
davidsiska-vega
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #671
PR adds the plumbing for integrating AMMs into market-sim and adds some AMM agents into the fuzzing for quick wins.
Examples:
Run a benchmark scenario with a static AMM (no base price updates).
AMM Scenario:
An AMM scenario has been added which modifies the benchmark scenario by adding a single AMM agent and a mean-reverting Ornstein-Uhlenbeck price process.
Plots show the basic mechanisms of the AMM agent behaving as expected.
Monte-Carlo Testing:
The AMM scenario was run multiple times with the following OH parameters:
Plots show expected behavior.