Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch yarn to npm #2131

Merged
merged 2 commits into from
Dec 11, 2024
Merged

chore: switch yarn to npm #2131

merged 2 commits into from
Dec 11, 2024

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Dec 10, 2024

πŸ“¦ Published PR as canary version: 2.3.1--canary.2131.2f5e0d3.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@arthurfiorette
Copy link
Collaborator

arthurfiorette commented Dec 11, 2024

pnpm would be a good move instead of npm... faster installs, faster ci, shell-emulator

@domoritz
Copy link
Member Author

But another thing to install besides node. I'll move to npm for now and maybe at some point we can consider pnpm for all of the Vega projects. I want to be consistent, though.

@domoritz domoritz merged commit ca95df1 into next Dec 11, 2024
3 checks passed
@domoritz domoritz deleted the dom/npm branch December 11, 2024 05:21
@domoritz
Copy link
Member Author

Moving ahead since npm install is 20s which is way faster than the 6m for tests. moving away from yarn is important since many people get confused that they need to install an old version (v1) of yarn.

Screenshot 2024-12-11 at 00 22 59

@arthurfiorette
Copy link
Collaborator

makes sense! good decision :)

Copy link

github-actions bot commented Jan 7, 2025

πŸš€ PR was released in v2.4.0-next.5 πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants